Tim Raupach
New member
Hi WRF team,
Looking at the functions that sum unstaggered and staggered tendency fields (add_a2c_u and add_a2c_v in module_physics_addtendc.F), I noticed that in add_a2c_v:
1. The loop over k is from kts to kte and not kts to ktf as in add_a2c_u, and
2. The if statements that reset the indices if the staggered dimension is periodic are testing the x dimension, not the y dimension. I.e. the lines
should probably read
I think this would only cause an issue if WRF was configured to be both nested/specified AND periodic.
Are these bugs that need a fix? If so I am happy to submit a pull request.
Thanks & cheers,
Tim
Looking at the functions that sum unstaggered and staggered tendency fields (add_a2c_u and add_a2c_v in module_physics_addtendc.F), I noticed that in add_a2c_v:
1. The loop over k is from kts to kte and not kts to ktf as in add_a2c_u, and
2. The if statements that reset the indices if the staggered dimension is periodic are testing the x dimension, not the y dimension. I.e. the lines
Code:
IF ( config_flags%periodic_x ) i_start = its
IF ( config_flags%periodic_x ) i_end = MIN( ite, ide-1 )
should probably read
Code:
IF ( config_flags%periodic_y ) j_start = jts
IF ( config_flags%periodic_y ) j_end = jte
I think this would only cause an issue if WRF was configured to be both nested/specified AND periodic.
Are these bugs that need a fix? If so I am happy to submit a pull request.
Thanks & cheers,
Tim