frame/module_quilt_outbuf_ops.F

Discussion/questions related to contributing code to the WRF model
Post Reply
kwthomas
Posts: 73
Joined: Tue Nov 06, 2018 10:25 pm

frame/module_quilt_outbuf_ops.F

Post by kwthomas » Mon Nov 12, 2018 11:20 pm

Comment out massive amounts of debug statements to stdout when using PNETCDF.
module_quilt_outbuf_ops.F
(69.51 KiB) Downloaded 43 times
Kevin W. Thomas
Center for Analysis and Prediction of Storms
University of Oklahoma
Norman, Oklahoma

kwerner
Posts: 2328
Joined: Wed Feb 14, 2018 9:21 pm

Re: frame/module_quilt_outbuf_ops.F

Post by kwerner » Tue Nov 13, 2018 5:57 pm

Hi,
Do these debug statements still print out when you set debug_level = 0 in the namelist? Thanks!
NCAR/MMM

kwthomas
Posts: 73
Joined: Tue Nov 06, 2018 10:25 pm

Re: frame/module_quilt_outbuf_ops.F

Post by kwthomas » Tue Nov 13, 2018 6:53 pm

Hi...

The code uses "wrf_message" for I/O. There is no checking for "debug_level".
Kevin W. Thomas
Center for Analysis and Prediction of Storms
University of Oklahoma
Norman, Oklahoma

kwerner
Posts: 2328
Joined: Wed Feb 14, 2018 9:21 pm

Re: frame/module_quilt_outbuf_ops.F

Post by kwerner » Tue Nov 13, 2018 11:38 pm

Thank you for pointing that out. Are you familiar with GitHub? We have our full repository on there, and that is where we make all modifications. If you have an account, you should be able to create a pull request (PR) for this. Our code can be found here: https://github.com/wrf-model/WRF
And then follow these steps:
1) Create your own fork from the top of our WRF code repository
2) Checkout the 'develop' branch
3) from that branch, create a new branch for your modifications
4) Once you're done, submit a PR and we will review it.

Some suggestions regarding this particular modification:
- instead of commenting out the debug statements, just simply remove them
- before submitting a PR, make sure to run a simple test to verify that results are the same before and after the mods (they should be, but we just have to make sure).

If the whole GitHub thing is completely foreign to you, no worries. We can handle the modifications, ourselves. Just let me know. Thanks!
NCAR/MMM

kwthomas
Posts: 73
Joined: Tue Nov 06, 2018 10:25 pm

Re: frame/module_quilt_outbuf_ops.F

Post by kwthomas » Wed Nov 14, 2018 6:47 pm

I've never use the GIT software.

The code probably should be modified to use "debug_level" instead of blindly deleting the writes's. I just
commented them out, which was easiest for me.
Kevin W. Thomas
Center for Analysis and Prediction of Storms
University of Oklahoma
Norman, Oklahoma

kwerner
Posts: 2328
Joined: Wed Feb 14, 2018 9:21 pm

Re: frame/module_quilt_outbuf_ops.F

Post by kwerner » Wed Nov 14, 2018 10:06 pm

Okay, we will create a PR for this and decide how to handle it within our group. Thanks for bringing it to our attention.
NCAR/MMM

kwerner
Posts: 2328
Joined: Wed Feb 14, 2018 9:21 pm

Re: frame/module_quilt_outbuf_ops.F

Post by kwerner » Fri Nov 30, 2018 12:17 am

Hi,
Just letting you know that I made some modifications and submitted a code change request. You can see the information here:
https://github.com/wrf-model/WRF/pull/716
Near the top, there are several tabs you can choose. If you click on "Files Changed," you can see the modifications I made.
NCAR/MMM

kwthomas
Posts: 73
Joined: Tue Nov 06, 2018 10:25 pm

Re: frame/module_quilt_outbuf_ops.F

Post by kwthomas » Fri Nov 30, 2018 8:53 pm

Thanks!
Kevin W. Thomas
Center for Analysis and Prediction of Storms
University of Oklahoma
Norman, Oklahoma

Post Reply

Return to “Code Contribution”